darkwiiplayer/nyooom
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix GC bug in reactive elements

Browse source
This commit is contained in:
Talia 2025-02-20 22:59:12 +01:00
parent ce416d994b
commit c3f4c9432f
Signed by: darkwiiplayer
GPG key ID: 7808674088232B3E
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
render.js
View file

@ -204,7 +204,7 @@ export class DomRenderer extends Renderer {
if (observable.value instanceof DocumentFragment) { if (observable.value instanceof DocumentFragment) {
throw "Failed to create reactive element: Document fragments cannot be replaced dynamically" throw "Failed to create reactive element: Document fragments cannot be replaced dynamically"
} }
const element = this.toElement(observable.value) const element = this.toElement(observable.value) || document.createComment("Reactive element Placeholder")
untilDeathDoThemPart(element, observable) untilDeathDoThemPart(element, observable)
let ref = new WeakRef(element) let ref = new WeakRef(element)
@ -217,6 +217,7 @@ export class DomRenderer extends Renderer {
if (element?.dispatchEvent(new BeforeReplaceEvent(next))) { if (element?.dispatchEvent(new BeforeReplaceEvent(next))) {
element.replaceWith(next) element.replaceWith(next)
next.dispatchEvent(new ReplacedEvent(element)) next.dispatchEvent(new ReplacedEvent(element))
untilDeathDoThemPart(next, observable)
element.dispatchEvent(new AfterReplaceEvent(next)) element.dispatchEvent(new AfterReplaceEvent(next))
ref = new WeakRef(next) ref = new WeakRef(next)
} }