darkwiiplayer/skooma-js
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity

Fix handling of document fragments in renderer

Browse source
This commit is contained in:
Talia 2024-07-31 09:30:17 +02:00
parent 6bd29f05dc
commit e763312f06
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
render.js
View file

@ -173,6 +173,8 @@ export class DomRenderer extends Renderer {
element.append(child) element.append(child)
else if (typeof arg == "function") else if (typeof arg == "function")
this.apply(element, arg(element) || empty) this.apply(element, arg(element) || empty)
else if (arg instanceof DocumentFragment)
element.append(arg)
else if (arg && typeof(arg)=="object") else if (arg && typeof(arg)=="object")
for (const key in arg) for (const key in arg)
if (element instanceof Element) if (element instanceof Element)
@ -225,6 +227,9 @@ export class DomRenderer extends Renderer {
* @return {Element|Text} * @return {Element|Text}
*/ */
static toReactiveElement(observable) { static toReactiveElement(observable) {
if (observable.value instanceof DocumentFragment) {
throw "Failed to create reactive element: Document fragments cannot be replaced dynamically"
}
const element = this.toElement(observable.value) const element = this.toElement(observable.value)
untilDeathDoThemPart(element, observable) untilDeathDoThemPart(element, observable)
let ref = new WeakRef(element) let ref = new WeakRef(element)